Open
Conversation
tknkaa
reviewed
Mar 9, 2026
Contributor
tknkaa
left a comment
tknkaa
left a comment
There was a problem hiding this comment.
プルリクエストのコメントにもあるように、惑星の移動速度も timeScale に合わせてスケールさせるのがいいかと思います。
|
|
||
| // 誤差による自転速度の異常上昇を防ぐ | ||
| api.angularVelocity.set(0, planet.rotationSpeedY, 0); | ||
| api.angularVelocity.set(0, planet.rotationSpeedY * timeScale, 0); |
Contributor
There was a problem hiding this comment.
ここは毎回 API を叩くと物理エンジンが計算した角速度を上書きしてしまうので、useEffect に切り出して変更があったときだけ上書きするのが良いと思います。誤差修正が目的なら、誤差を計算して閾値を超えたときだけこの API を呼ぶようにしてください。
| } | ||
|
|
||
| // 計算した力を重心に適用 | ||
| forceAccumulator.multiplyScalar(timeScale); |
Contributor
There was a problem hiding this comment.
ここはtimeScaleの2乗をかけるのが正しいらしいです。
forceAccumulator.multiplyScalar(timeScale * timeScale);
Deploying space-simulator with
|
| Latest commit: |
1f84ef9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ae0c67c.space-simulator.pages.dev |
| Branch Preview URL: | https://feature-parameters.space-simulator.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timeScaleを実装したが、惑星の移動はcannon.jsが管理しているっぽいので時間を移動に反映させるのは難しかった。（現在の速度をtimeScale倍してごまかしてもいいかも）
timeScaleで変わるのは現在は自転速度と爆発のモーションくらい